Fixes #2568. Updates the code so on exception in generated quantities, all generated quantities are NaN #2571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Fixes the behavior in
mcmc_writer
so that when there's an exception thrown in the model's generated quantities block, it writes out the parameter values andNaN
for any generated quantity.Intended Effect
Changes the behavior so that the number of draws is the number of iterations.
How to Verify
There's an updated unit test that verifies that the right terms are
NaN
.If you run the model in issue #2568, there are now the right number of posterior draws with the rejections forcing all of the generated quantities to output
NaN
.Side Effects
This fixes weird behavior of differing chain lengths.
This may affect the interfaces if they aren't accepting
NaN
as a valid value.Documentation
None.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Generable
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: