Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nondeterminism in multi-Pathfinder #3239

Merged
merged 2 commits into from Nov 6, 2023

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

The current design is such that the order of the single-pathfinder draws is determined by the order their thread completes, so a random seed does not always produce the same output of multi-pathfinder.

More details are given in #3237

Intended Effect

Closes #3237

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian merged commit d8a367e into develop Nov 6, 2023
3 checks passed
@WardBrian WardBrian deleted the fix/3237-pathfinder-concurrent-vector branch November 6, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathfinder run not reproducible from seed
3 participants