-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of separator directives and feature selection #75
Conversation
@@ -53,4 +53,5 @@ def main(args): | |||
) | |||
evalstream = tag.bae.eval_stream(locusstream) | |||
writer = tag.writer.GFF3Writer(evalstream, args.out) | |||
writer.complex_separators = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we want separators to mark boundaries between loci, not between features within a locus.
@@ -58,4 +58,5 @@ def main(args): | |||
minperc=args.min_perc | |||
) | |||
writer = tag.writer.GFF3Writer(locusstream, args.out) | |||
writer.complex_separators = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we want separators to mark boundaries between loci, not between features within a locus.
@@ -103,8 +103,6 @@ def __repr__(self): | |||
if string != '': | |||
string += '\n' | |||
string += str(feature) | |||
if self.is_complex: | |||
string += '\n###' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now delegated to the GFF3 writer.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 1269 1278 +9
Branches 290 292 +2
=====================================
+ Hits 1269 1278 +9
Continue to review full report at Codecov.
|
This update mashes together two changes. First, it gives finer control to how and when separator directives are printed after complex features. Second, it enables selection of multiple feature types simultaneously in the
tag.select.features
function and updates thebae
module to correctly use this function intraverse
mode.API documentation up-to-date? Docstring examples?