Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow eslint-plugin-promise v6 as peer dependency #200

Closed
J3m5 opened this issue Dec 23, 2021 · 2 comments · Fixed by #193
Closed

Allow eslint-plugin-promise v6 as peer dependency #200

J3m5 opened this issue Dec 23, 2021 · 2 comments · Fixed by #193

Comments

@J3m5
Copy link

J3m5 commented Dec 23, 2021

What version of this package are you using?
16.0.3

What operating system, Node.js, and npm version?
Linux Mint 20.2 | Node.js 16.13.1 | npm 8.3.0

What happened?
I upgraded eslint-plugin-promise to version 6.0 and run npm install

npm WARN ERESOLVE overriding peer dependency
npm WARN Found: eslint-plugin-promise@5.2.0
npm WARN node_modules/eslint-plugin-promise
npm WARN   dev eslint-plugin-promise@"6.0.0" from the root project
npm WARN   1 more (eslint-config-standard)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer eslint-plugin-promise@"^4.2.1 || ^5.0.0" from eslint-config-standard@16.0.3
npm WARN node_modules/eslint-config-standard
npm WARN   dev eslint-config-standard@"16.0.3" from the root project
npm WARN   1 more (standard)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! Found: eslint-plugin-promise@6.0.0
npm ERR! node_modules/eslint-plugin-promise
npm ERR!   dev eslint-plugin-promise@"6.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-promise@"^4.2.1 || ^5.0.0" from eslint-config-standard@16.0.3
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"16.0.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

What did you expect to happen?
npm install not failing

Are you willing to submit a pull request to fix this bug?
Yes

@daphnesmit
Copy link

Can we merge this? :D

@J3m5
Copy link
Author

J3m5 commented Dec 27, 2021

Looks like dependabot disagree
TonyRL/docker-notify#31 (comment)
😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants