Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md add standardx #1178

Merged
merged 1 commit into from
Aug 13, 2018
Merged

README.md add standardx #1178

merged 1 commit into from
Aug 13, 2018

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Aug 13, 2018

I just discovered standardx from #400 (comment), please include!

@welcome
Copy link

welcome bot commented Aug 13, 2018

🙌 Thanks for opening this pull request! You're awesome.

README.md Outdated
@@ -798,6 +798,7 @@ There are also many **[editor plugins](#are-there-text-editor-plugins)**, a list
**[npm packages that use `standard`](https://github.com/standard/standard-packages)**,
and an awesome list of
**[packages in the `standard` ecosystem](https://github.com/standard/awesome-standard)**.
- **[standardx](https://github.com/standard/standardx)** - standard, with custom tweaks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this in conjunction with the list? Basically move this line 5 lines up, so it's right after semistandard.

@brodycj
Copy link
Contributor Author

brodycj commented Aug 13, 2018

Just moved the entry as requested, looking forward to the merge:)

Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@LinusU
Copy link
Member

LinusU commented Aug 13, 2018

failing because of eddiemoore/gulp-codecov#69, merging anyway

@LinusU LinusU merged commit b6919b4 into standard:master Aug 13, 2018
@welcome
Copy link

welcome bot commented Aug 13, 2018

🎉 Congrats on getting your first pull request landed!

@brodycj
Copy link
Contributor Author

brodycj commented Aug 13, 2018

Thanks @LinusU! I already raised alternative PRs to resolve the build failure and cleanup the duplicate entry:

@brodycj brodycj deleted the patch-1 branch August 13, 2018 16:59
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants