-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the built-in ESLint reporter (Stylish) #218
Use the built-in ESLint reporter (Stylish) #218
Conversation
This commit refactors Standard to report errors using the built-in reporter in ESLint.
Unfortunately, I don't think this will get merged...
And:
I definitely recommend checking out snazzy! |
Snazzy it is then! |
I'm afraid this change will break the editor tools that rely on the current output format on stdout. We could try to detect if standard is running in a TTY (with |
I would love to see some nicer output from standard, but I don't think that the extra effort (although small) of using snazzy outweighs that need. I'm +1 on this getting merged thought, maybe with |
It's best to just keep it the same. You can never predict how consumers of your software will use it. |
Thanks for the PR, but we don't need this feature in core. There are many of modules that style the output - it's not that hard to parse. The built-in reporter works just fine, but there's also snazzy, standard-json, and standard-tap for specific styles. Also standard-reporter supports a bunch more. |
This PR refactors Standard to report errors using the built-in reporter in ESLint.
Before:
After: