add e2e tests

standardnotes · Jan 11, 2024 · e485db5 · e485db5
1 parent 9bb4538
commit e485db5
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 0 deletions.
diff --git a/packages/services/src/Domain/Application/Options/OptionalOptions.ts b/packages/services/src/Domain/Application/Options/OptionalOptions.ts
@@ -18,6 +18,9 @@ export interface ApplicationOptionalConfiguratioOptions {
    */
   webSocketUrl?: string
 
+  /**
+   * Amount sync calls allowed per minute.
+   */
   syncCallsThresholdPerMinute?: number
 
   /**

diff --git a/packages/snjs/mocha/lib/Applications.js b/packages/snjs/mocha/lib/Applications.js
@@ -22,6 +22,7 @@ export function createApplicationWithOptions({ identifier, environment, platform
     defaultHost: host || Defaults.getDefaultHost(),
     appVersion: Defaults.getAppVersion(),
     webSocketUrl: Defaults.getDefaultWebSocketUrl(),
+    syncCallsThresholdPerMinute: Defaults.DEFAULT_SYNC_CALLS_THRESHOLD_PER_MINUTE,
   })
 }
 

diff --git a/packages/snjs/mocha/lib/Defaults.js b/packages/snjs/mocha/lib/Defaults.js
@@ -1,5 +1,7 @@
 export const DefaultServerPort = 3123
 
+export const DEFAULT_SYNC_CALLS_THRESHOLD_PER_MINUTE = 100
+
 export function getDefaultHost() {
   return `http://localhost:${DefaultServerPort}`
 }

diff --git a/packages/snjs/mocha/sync_tests/online.test.js b/packages/snjs/mocha/sync_tests/online.test.js
@@ -1,6 +1,7 @@
 import { BaseItemCounts } from '../lib/BaseItemCounts.js'
 import * as Factory from '../lib/factory.js'
 import * as Utils from '../lib/Utils.js'
+import * as Defaults from '../lib/Defaults.js'
 
 chai.use(chaiAsPromised)
 const expect = chai.expect
@@ -433,6 +434,22 @@ describe('online syncing', function () {
     expect(allItems.length).to.equal(expectedItemCount)
   })
 
+  it('should defer syncing if syncing is breaching the sync calls per minute threshold', async function () {
+    const safeGuard = application.dependencies.get(TYPES.SyncFrequencyGuard)
+
+    let syncCount = 0
+    while(!safeGuard.isSyncCallsThresholdReachedThisMinute()) {
+      await application.sync.sync({
+        onPresyncSave: () => {
+          syncCount++
+        }
+      })
+    }
+
+    expect(safeGuard.isSyncCallsThresholdReachedThisMinute()).to.equal(true)
+    expect(syncCount < Defaults.DEFAULT_SYNC_CALLS_THRESHOLD_PER_MINUTE).to.equal(true)
+  })
+
   it('items that are never synced and deleted should not be uploaded to server', async function () {
     const note = await Factory.createMappedNote(application)
     await application.mutator.setItemDirty(note)