chore: fix eslint crashing issues

common.eslintrc.js

@@ -0,0 +1,60 @@
+module.exports = {
+  root: true,
+  parser: '@typescript-eslint/parser',
+  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  plugins: ['@typescript-eslint', 'prettier'],
+  ignorePatterns: ['**/*.spec.ts'],
+  rules: {
+    'standard/no-callback-literal': 0, // Disable this as we have too many callbacks relying on literals
+    'no-throw-literal': 0,
+    camelcase: 'off',
+    'sort-imports': 'off',
+    'eol-last': 'error',
+    'no-multiple-empty-lines': ['error', { max: 1, maxEOF: 0 }],
+    'no-trailing-spaces': 'error',
+    '@typescript-eslint/no-explicit-any': 'warn',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        vars: 'all',
+        args: 'after-used',
+        ignoreRestSiblings: false,
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      },
+    ],
+    '@typescript-eslint/no-floating-promises': ['error'],
+    'block-scoped-var': 'error',
+    'comma-dangle': ['error', 'always-multiline'],
+    curly: ['error', 'all'],
+    'no-confusing-arrow': 'error',
+    'no-inline-comments': 'warn',
+    'no-invalid-this': 'error',
+    'no-return-assign': 'warn',
+    'no-constructor-return': 'error',
+    'no-duplicate-imports': 'error',
+    'no-self-compare': 'error',
+    'no-console': ['error', { allow: ['warn', 'error'] }],
+    'no-unmodified-loop-condition': 'error',
+    'no-unused-private-class-members': 'error',
+    'object-curly-spacing': ['error', 'always'],
+    quotes: ['error', 'single', { avoidEscape: true }],
+    semi: ['error', 'never'],
+    'prettier/prettier': [
+      'error',
+      {
+        singleQuote: true,
+        trailingComma: 'all',
+        printWidth: 120,
+        semi: false,
+      },
+      {
+        usePrettierrc: false,
+      },
+    ],
+  },
+}

packages/api/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/api/package.json

@@ -21,8 +21,8 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
-    "lint:fix": "eslint . --ext .ts --fix",
+    "lint": "eslint src --ext .ts",
+    "lint:fix": "eslint src --ext .ts --fix",
     "test": "jest spec --coverage"
   },
   "devDependencies": {

packages/desktop/.eslintrc.js

@@ -0,0 +1,16 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts', '@types', 'node_modules', 'dist'],
+  rules: {
+    'no-console': ['warn', { allow: ['warn', 'error'] }],
+    '@typescript-eslint/no-var-requires': 'off',
+  },
+  globals: {
+    zip: true,
+  },
+}

packages/desktop/app/javascripts/Renderer/Renderer.ts

@@ -41,7 +41,7 @@ const loadAndStartApplication = async () => {
 
   window.device = await createDesktopDevice(remoteBridge)
 
-  window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL)
+  return window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL)
 }
 
 window.onload = () => {
@@ -154,5 +154,5 @@ window.electronMainEvents.handleWindowFocused(() => {
 })
 
 window.electronMainEvents.handleInstallComponentComplete((_: IpcRendererEvent, data: any) => {
-  window.webClient.onComponentInstallationComplete(data.component, undefined)
+  void window.webClient.onComponentInstallationComplete(data.component, undefined)
 })

packages/desktop/package.json

@@ -22,8 +22,8 @@
     "dev": "NODE_ENV=development webpack --config desktop.webpack.dev.js --watch",
     "format": "prettier --write .",
     "lint:eslint": "eslint app/index.ts app/application.ts app/javascripts/**/*.ts",
-    "lint:formatting": "prettier --check .",
-    "lint": "yarn lint:formatting && yarn lint:eslint",
+    "lint:formatting": "prettier --check app",
+    "lint": "yarn lint:formatting && yarn lint:eslint app",
     "tsc": "tsc --noEmit",
     "release:mac": "node scripts/build.mjs mac",
     "start": "electron ./app --enable-logging --icon _icon/icon.png",
@@ -58,7 +58,6 @@
     "@types/proxyquire": "^1.3.28",
     "@types/yauzl": "^2.10.0",
     "ava": "^4.3.3",
-    "babel-eslint": "^10.1.0",
     "babel-loader": "^8.2.5",
     "copy-webpack-plugin": "^10.2.4",
     "electron-builder": "23.3.3",

packages/encryption/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/encryption/package.json

@@ -18,7 +18,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "format": "prettier --write src",
     "test": "jest"
   },

packages/features/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/features/package.json

@@ -21,7 +21,7 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "dependencies": {
@@ -32,7 +32,8 @@
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
-    "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "@typescript-eslint/eslint-plugin": "*",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5",

packages/filepicker/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/filepicker/example/package.json

@@ -24,7 +24,6 @@
     "@babel/preset-typescript": "^7.15.0",
     "@standardnotes/config": "^2.2.0",
     "@types/wicg-native-file-system": "^2020.6.0",
-    "babel-eslint": "^10.1.0",
     "babel-loader": "^8.2.3",
     "html-webpack-plugin": "^5.5.0",
     "ts-loader": "^9.2.6",

packages/filepicker/package.json

@@ -19,12 +19,13 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5",

packages/files/.eslintrc.js

@@ -0,0 +1,9 @@
+module.exports = {
+  root: true,
+  extends: ['../../common.eslintrc.js'],
+  parserOptions: {
+    project: './tsconfig.json',
+    tsconfigRootDir: __dirname,
+  },
+  ignorePatterns: ['**/*.spec.ts'],
+}

packages/files/package.json

@@ -19,12 +19,13 @@
     "start": "tsc -p tsconfig.json --watch",
     "prebuild": "yarn clean",
     "build": "tsc -p tsconfig.json",
-    "lint": "eslint . --ext .ts",
+    "lint": "eslint src --ext .ts",
     "test": "jest"
   },
   "devDependencies": {
     "@types/jest": "^28.1.5",
     "@typescript-eslint/eslint-plugin": "^5.30.0",
+    "eslint": "*",
     "eslint-plugin-prettier": "*",
     "jest": "^28.1.2",
     "ts-jest": "^28.0.5"