Fix issues with our docker builds #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spotify skill uses wget to download spotifyd, and it expects wget will be there. Addresses #201
gcampax
force-pushed
the
wip/fix-docker-issues
branch
5 times, most recently
from
946b2d8
to
9fe69fc
Compare
While our application to Docker Open Source is under review, builds on DockerHub are not available. Instead, set up travis to build our docker images. The full build is done with "docker buildx", which in theory lets us build images for other architectures. In practice, the normal build (changing the base image to an arch specific image) works for ARM but fails in "docker buildx", and I'm not sure exactly why.
gcampax
force-pushed
the
wip/fix-docker-issues
branch
from
9fe69fc
to
2439bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #201 and #228