Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support features for faq, timezone, and configured devices #856

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

jmhw0123
Copy link
Contributor

No description provided.

@jmhw0123 jmhw0123 self-assigned this Dec 24, 2021
@jmhw0123 jmhw0123 marked this pull request as draft December 24, 2021 02:40
@jmhw0123 jmhw0123 force-pushed the wip/faq-fix branch 3 times, most recently from 3ba1666 to 6dfbd36 Compare December 24, 2021 05:53
Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a few comments.

q:
- What do you like to do?
a:
- Let me think...I like volunteering. It is satisfying when a person thanks me for helping them accomplish something or even just spending time with them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write multiple answers? Just so we're not repetitive (They'll be randomly selected)

lib/engine/devices/builtins/thingengine.builtin.ts Outdated Show resolved Hide resolved
@gcampax
Copy link
Contributor

gcampax commented Dec 27, 2021

Oh you'll need to update the reference files used by the translation tests because you updated the builtin manifest.

@gcampax gcampax marked this pull request as ready for review December 28, 2021 19:03
@gcampax gcampax merged commit a11e20c into master Dec 28, 2021
@gcampax gcampax deleted the wip/faq-fix branch December 28, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants