Make ClassDescriptor deterministic #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods, particularly overloads.
daniel-beck
reviewed
May 23, 2017
| public HttpResponse doX(StaplerRequest req, StaplerResponse rsp) { | ||
| return HttpResponses.plainText("doX(StaplerRequest, StaplerResponse)"); | ||
| } | ||
| @WebMethod(name = "x") |
There was a problem hiding this comment.
So this means that a magically named method will have precedence over a @WebMethod? This seems counterintuitive.
There was a problem hiding this comment.
Then deprecate your other overloads. Again, the exact ordering of (nondeprecated) methods is arbitrary, so long as it is predictable so any field errors can be reproduced by developers. If you have more than one, you are in the wrong.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
+0.5 |
|
@reviewbybees done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has sometimes been observed that a web method with multiple overloads will randomly run one or the other (according to JVM implementation details), which is confusing and can lead to bugs, especially if all but one overload was intentionally deprecated. This patch simply picks one nondeprecated overload consistently so there are no surprises (as in junit-team/junit4#293 for example).
@reviewbybees