Move histogram creation of reference pulser outside of daQA flag #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l setters from etofIn001 version of this file. Needed to unpack Get4Status bit into event files
…librations in the repository version. Nessecary only for creating calibrations, but should be available in the offical code. Added calculation of goodEventFlag for every counter from Get4 missmatch bits and pulser digis.
…librations in the repository version. Nessecary only for creating calibrations, but should be available in the offical code. Added calculation of goodEventFlag for every counter from Get4 missmatch bits and pulser digis.
…ect header version after rebase without increment
…base. Decremented etof collection ClassDef for real this time
starsdong
approved these changes
Nov 9, 2021
|
Thank you, Philipp. I added Gene to review/approve this. Gene, if you can have a check to see whether we can proceed. |
genevb
approved these changes
Nov 9, 2021
|
Dmitri, could you please take a look at the CI issue and help instruct Philipp how to resolve if needed? We wanted to resolve this asap for the next production library (SL21d) build. Thanks |
|
Looks like a glitch on the GitHub side. Just restart the jobs when it happens |
|
How do i do this? Submit an empty commit?
November 10, 2021 2:46 PM, "Dmitri Smirnov" ***@***.*** ***@***.******@***.***>)> wrote:
Looks like a glitch on the GitHub side. Just restart the jobs when it happens
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#182 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AIXRR2U56MPL5B66GBUQIADULJZULANCNFSM5HVZS4ZA).
Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).
|
plexoos
changed the title
jml985
pushed a commit
that referenced
this pull request
Dec 7, 2021
* fixed 64b integer conversion in getField() method and added additional setters from etofIn001 version of this file. Needed to unpack Get4Status bit into event files * merged with group development to have support for local run-by-run calibrations in the repository version. Nessecary only for creating calibrations, but should be available in the offical code. Added calculation of goodEventFlag for every counter from Get4 missmatch bits and pulser digis. * merged with group development to have support for local run-by-run calibrations in the repository version. Nessecary only for creating calibrations, but should be available in the offical code. Added calculation of goodEventFlag for every counter from Get4 missmatch bits and pulser digis. * <strstring.h> header include needed to be added for local compilation (?) * added eTofGoodEventFlag to mark counters which are good foer analysis in each event * moved struct to public to avoid root6 issue. Changed class dev version back to 0 * added kStFatal return in ::init if calib histo files are corrupt * Changed class dev version back to 0 * Trying to fix merger * Trying to fix merger * added eTofGoodEventFlag to mark counters which are good foer analysis in each event * moved struct to public to avoid root6 issue. Changed class dev version back to 0 * added kStFatal return in ::init if calib histo files are corrupt * Changed class dev version back to 0 * decremented classDef version of StEtofCollection. Makers compile correct header version after rebase without increment * removed double line in MuEtofHeader constructor * included eTOF constants header and moved constants here * included eTOF constants header and moved constants here * added constant nbGet4s here for use in event headers * Removed strstr include in StMuDstMaker.cxx. Now indentical to repository version * Moved vector init in eTOF headers to initializer list * Changed default reference pulser setting in calib maker back to data base. Decremented etof collection ClassDef for real this time * Moved reference pulser histogram creation outside of doQA flag. Fixing Issue #181 Co-authored-by: Philipp Weidenkaff <weidenkaff@rcas6005.rcf.bnl.gov> Co-authored-by: PhilippWeidenkaff <weidenkaff@physi.uni-heildeberg.de>
marrbnl
pushed a commit
that referenced
this pull request
Dec 8, 2021
* fixed 64b integer conversion in getField() method and added additional setters from etofIn001 version of this file. Needed to unpack Get4Status bit into event files * merged with group development to have support for local run-by-run calibrations in the repository version. Nessecary only for creating calibrations, but should be available in the offical code. Added calculation of goodEventFlag for every counter from Get4 missmatch bits and pulser digis. * merged with group development to have support for local run-by-run calibrations in the repository version. Nessecary only for creating calibrations, but should be available in the offical code. Added calculation of goodEventFlag for every counter from Get4 missmatch bits and pulser digis. * <strstring.h> header include needed to be added for local compilation (?) * added eTofGoodEventFlag to mark counters which are good foer analysis in each event * moved struct to public to avoid root6 issue. Changed class dev version back to 0 * added kStFatal return in ::init if calib histo files are corrupt * Changed class dev version back to 0 * Trying to fix merger * Trying to fix merger * added eTofGoodEventFlag to mark counters which are good foer analysis in each event * moved struct to public to avoid root6 issue. Changed class dev version back to 0 * added kStFatal return in ::init if calib histo files are corrupt * Changed class dev version back to 0 * decremented classDef version of StEtofCollection. Makers compile correct header version after rebase without increment * removed double line in MuEtofHeader constructor * included eTOF constants header and moved constants here * included eTOF constants header and moved constants here * added constant nbGet4s here for use in event headers * Removed strstr include in StMuDstMaker.cxx. Now indentical to repository version * Moved vector init in eTOF headers to initializer list * Changed default reference pulser setting in calib maker back to data base. Decremented etof collection ClassDef for real this time * Moved reference pulser histogram creation outside of doQA flag. Fixing Issue #181 Co-authored-by: Philipp Weidenkaff <weidenkaff@rcas6005.rcf.bnl.gov> Co-authored-by: PhilippWeidenkaff <weidenkaff@physi.uni-heildeberg.de>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved histogram creation of reference pulser outside of daQA flag. Fixes #181