Tuning up TpcRS for AuAu19GeV 2019 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisyak
requested review from
akioogawa,
dmarkh,
fgeurts,
iraklic,
klendathu2k and
plexoos
as code owners
iraklic
approved these changes
Nov 10, 2021
veprbl
approved these changes
Nov 11, 2021
plexoos
approved these changes
Nov 11, 2021
|
Dmitry and Jason, it seems the changes involves some updates in StDb/idl and g2t tables. Could you please take a review and comment/approve this PR? Thanks |
klendathu2k
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
I approve this pull request, but take note of an issue it raises with the event data model.
Changes to pams/sim/idl/g2t_tpc_hit.idl introduce data members which are used to store intermediate calculations from TpcRS. This adds an additional responsibility to the hit structure. It represents both the MC event data model AND tpc internal calculations.
In an ideal design, these responsibilities would be kept separate. A parallel data structure in StTpcRSMaker would be preferred over changing the simulation data format.
jml985
pushed a commit
that referenced
this pull request
Dec 7, 2021
marrbnl
pushed a commit
that referenced
this pull request
Dec 8, 2021
plexoos
pushed a commit
that referenced
this pull request
Dec 13, 2021
plexoos
pushed a commit
that referenced
this pull request
Dec 13, 2021
plexoos
pushed a commit
that referenced
this pull request
Dec 14, 2021
(cherry picked from commit b91e0fd)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.