Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): try to fix wal ut TempDir not deleted error #1113

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Sep 2, 2022

Description

after WAL UTs are executed, temp dirs are not deleted

before pr code:

image

after pr code:

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3 milestone Sep 2, 2022
@anda-ren anda-ren self-assigned this Sep 2, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 0db5b10 into star-whale:main Sep 2, 2022
@anda-ren anda-ren deleted the wal_ut_fix branch September 2, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants