Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): add only_standalone decorator for cli view #1258

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

tianweidut
Copy link
Member

Description

provide more user-friendly output for standalone commands.

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request client 🌈 labels Sep 20, 2022
@tianweidut tianweidut added this to the v0.3 milestone Sep 20, 2022
@tianweidut tianweidut self-assigned this Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1258 (2152989) into main (b7a536c) will increase coverage by 11.90%.
The diff coverage is 92.59%.

@@              Coverage Diff              @@
##               main    #1258       +/-   ##
=============================================
+ Coverage     73.79%   85.70%   +11.90%     
=============================================
  Files           287       62      -225     
  Lines         13312     7016     -6296     
  Branches        646        0      -646     
=============================================
- Hits           9824     6013     -3811     
+ Misses         3268     1003     -2265     
+ Partials        220        0      -220     
Flag Coverage Δ
controller ?
standalone 85.70% <92.59%> (+0.01%) ⬆️
unittests 85.70% <92.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/bundle.py 91.97% <ø> (-0.06%) ⬇️
client/starwhale/base/view.py 83.75% <81.81%> (-0.21%) ⬇️
client/starwhale/core/dataset/model.py 73.09% <100.00%> (ø)
client/starwhale/core/dataset/view.py 55.55% <100.00%> (+0.38%) ⬆️
client/starwhale/core/eval/view.py 65.43% <100.00%> (+0.16%) ⬆️
client/starwhale/core/model/model.py 85.59% <100.00%> (ø)
client/starwhale/core/model/view.py 69.14% <100.00%> (+1.01%) ⬆️
client/starwhale/core/runtime/model.py 92.88% <100.00%> (ø)
client/starwhale/core/runtime/view.py 91.86% <100.00%> (+0.56%) ⬆️
client/starwhale/api/_impl/model.py 91.51% <0.00%> (-0.11%) ⬇️
... and 225 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 9212bf9 into star-whale:main Sep 20, 2022
@tianweidut tianweidut deleted the enhance/standalone-only branch April 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants