Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller):set datastore api param 'ignoreNonExistingTable'=true #1297

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 23, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added bug 🐛 Something isn't working ban-e2e 🚫 labels Sep 23, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1297 (08fa1a1) into main (7c35873) will decrease coverage by 12.34%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1297       +/-   ##
=============================================
- Coverage     74.53%   62.18%   -12.35%     
- Complexity     1235     1236        +1     
=============================================
  Files           288      225       -63     
  Lines         13394     6355     -7039     
  Branches        653      654        +1     
=============================================
- Hits           9983     3952     -6031     
+ Misses         3188     2180     -1008     
  Partials        223      223               
Flag Coverage Δ
controller 62.18% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/datastore/DataStore.java 94.25% <100.00%> (+0.10%) ⬆️
client/starwhale/core/model/view.py
client/starwhale/utils/progress.py
client/starwhale/core/eval/executor.py
client/starwhale/core/runtime/view.py
client/starwhale/consts/env.py
client/starwhale/core/model/default_handler.py
client/starwhale/core/eval/view.py
client/starwhale/api/_impl/model.py
client/starwhale/api/_impl/metric.py
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit c2b343f into star-whale:main Sep 23, 2022
@goldenxinxing goldenxinxing deleted the fix/datastore_scan_error_when_request_cloud_2 branch April 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ban-e2e 🚫 bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants