Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(controller): unit test for bundle/runtime/swmp/swds managers and services and fix some bugs #1323

Merged
merged 9 commits into from
Oct 12, 2022

Conversation

dreamlandliu
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 30, 2022
anda-ren
anda-ren previously approved these changes Oct 11, 2022
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1323 (769cc5f) into main (08c8674) will decrease coverage by 2.39%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##               main    #1323      +/-   ##
============================================
- Coverage     76.86%   74.47%   -2.40%     
- Complexity     1404     1557     +153     
============================================
  Files           294      230      -64     
  Lines         13880     6671    -7209     
  Branches        705      705              
============================================
- Hits          10669     4968    -5701     
+ Misses         2968     1430    -1538     
- Partials        243      273      +30     
Flag Coverage Δ
controller 74.47% <94.11%> (+7.23%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...whale/mlops/domain/swmp/SwModelPackageService.java 75.55% <92.00%> (+75.08%) ⬆️
.../starwhale/mlops/domain/swds/SwDatasetService.java 86.99% <94.44%> (+86.09%) ⬆️
...starwhale/mlops/domain/runtime/RuntimeService.java 73.73% <95.23%> (+73.24%) ⬆️
...i/starwhale/mlops/domain/bundle/BundleManager.java 100.00% <100.00%> (ø)
...va/ai/starwhale/mlops/domain/swmp/SwmpManager.java 75.67% <100.00%> (+51.35%) ⬆️
client/starwhale/base/cloud.py
client/starwhale/core/dataset/type.py
client/starwhale/base/store.py
client/starwhale/base/bundle.py
client/starwhale/core/instance/model.py
... and 77 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 03610b0 into star-whale:main Oct 12, 2022
@dreamlandliu dreamlandliu deleted the ut/controller_0930 branch January 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants