Migrate to new adapter testing framework #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
from
9a7d54c
to
0fb1a03
Compare
jtcohen6
reviewed
Apr 22, 2022
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
5 times, most recently
from
b581d52
to
a3d10f6
Compare
hovaesco
commented
Apr 26, 2022
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
from
a3d10f6
to
668d54f
Compare
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
from
668d54f
to
68a7d27
Compare
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
from
68a7d27
to
48c5c93
Compare
|
@hovaesco are we planning to move to a structure similar to the dbt-snowflake adapter ? |
|
Snowflake uses old tests structure in the folder you sent. We are moving to the new one. |
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
from
48c5c93
to
6736940
Compare
findinpath
reviewed
May 4, 2022
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
3 times, most recently
from
211d0b0
to
fd4954f
Compare
findinpath
reviewed
May 4, 2022
|
This PR looks very good. A few minor comments are still open. |
hovaesco
force-pushed
the
hovaesco/testing-framework-v1.1
branch
from
fd4954f
to
d967d92
Compare
findinpath
approved these changes
May 4, 2022
findinpath
reviewed
May 5, 2022
| # seed seeds | ||
| results = run_dbt(["seed"], expect_pass=True) | ||
| assert len(results) == 1 | ||
| # run models two times to check on_table_exists = 'drop' |
There was a problem hiding this comment.
We could use the same mechanism as in test-incremental to change the seed before running the second time. This way, the test looks more realistic.
This was referenced May 5, 2022
EminUZUN
pushed a commit
to EminUZUN/dbt-trino
that referenced
this pull request
Feb 14, 2023
…ng-framework-v1.1 Migrate to new adapter testing framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist
README.mdupdated and added information about my changeCHANGELOG.mdupdated and added information about my change