Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] move the repo to https://github.com/move-language #37

Open
jiangying000 opened this issue Sep 30, 2022 · 1 comment
Open

[dev] move the repo to https://github.com/move-language #37

jiangying000 opened this issue Sep 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jiangying000
Copy link
Collaborator

jiangying000 commented Sep 30, 2022

move-language/mainstarcoinorg/dev 比较大的差异在

  1. 默认输出长/短地址,实现和测试都会有不同
  2. move 模块名字大小写,0x1::Vector vs 0x1::vector 这种会有比较多的diff,要 revert 一些 move-language/main 下面的 commit

问题:

  1. move-language 的 starcoin 分支是直接在 move-language/main 最新 commit 的基础上增加 commit 吗?还是把现在的starcoinorg/move:dev 或者 starcoinorg/move:starcoin-main 直接搬过去?
  2. 使用starcoin/starcoin-main/ stc作为 move-language/move 仓库下的分支名称?
  3. 先把分支建起来,直接迁移,然后在move-language仓库下提pr,还是等这边更新的差不多了,再迁移?
  4. 如果迁移了,再move-language下工作,提pr的时候ci是不是会自动跑了?
  5. 可能需要 move-language 给开个分支,以及对特定分支的 review 和写入权限

@jolestar @nkysg

@jiangying000 jiangying000 added the enhancement New feature or request label Sep 30, 2022
@jiangying000 jiangying000 changed the title [dev] move the repo to https://github.com/move-language [dev] about move the repo to https://github.com/move-language Sep 30, 2022
@jiangying000 jiangying000 changed the title [dev] about move the repo to https://github.com/move-language [dev] move the repo to https://github.com/move-language Sep 30, 2022
@jolestar
Copy link
Member

jolestar commented Sep 30, 2022

我觉得可以是这个方案:

  1. 等长短地址那个 PR 合并进去。
  2. 当前的 dev 分支是基于 move-language/move 的 main 分支基础上改的,运行在 proxima 网络上,我们可以先把这个分支搬过去,作为未来的 starcoin 的主分支。 starcoinorg/move:starcoin-main 只合并 bug fix。
  3. 等我们准备好了,可以申请 move-language 的分支。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants