Feature/6.0 #26
Merged
Feature/6.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klinovp
reviewed
Nov 7, 2018
build.gradle
Outdated
| @@ -5,7 +5,7 @@ task wrapper(type: Wrapper) { | |||
| } | |||
|
|
|||
| ext { | |||
| stardogVersion = project.hasProperty("stardogVersion") ? project.getProperty("stardogVersion") : '5.3.0' | |||
| stardogVersion = project.hasProperty("stardogVersion") ? project.getProperty("stardogVersion") : '6.0.0-SNAPSHOT-20181105' | |||
There was a problem hiding this comment.
Should this be SNAPSHOT or just 6.0.0? These changes won't be merged till 6.0 is out, right?
There was a problem hiding this comment.
I definitely meant to have 6.0.0 here, actually. I was having versioning issues, so I guess this accidentally stuck around.
| // You're not restricted to adding, or removing, data from a file. You can create `Statement` objects | ||
| // containing information you want to add or remove from the database and make the modification wrt | ||
| // that graph. Here we'll add a statement that we want added to our database. | ||
| Statement aStatement = Values.statement(Values.iri("uri:subj"), |
| @@ -139,7 +138,7 @@ private static void printCounts(final Connection theConn) throws StardogExceptio | |||
| "}"); | |||
|
|
|||
| aQuery.parameter("type", PERSON); | |||
| TupleQueryResult aResult = aQuery.execute(); | |||
| SelectQueryResult aResult = aQuery.execute(); | |||
There was a problem hiding this comment.
Shouldn't we use try-with-resources here as well?
| System.out.println(result.getValue("s") + " with a score of: " + ((Literal) result.getValue("score")).doubleValue()); | ||
| Optional<Value> s = result.value("s"); | ||
| Optional<Literal> score = result.literal("score"); | ||
| if (s.isPresent() && score.isPresent()) { |
There was a problem hiding this comment.
This means we won't print the literal if it's present but the score is missing. I know it probably won't happen but it looks slightly odd and it's not the behaviour we had before.
| @@ -48,8 +48,8 @@ | |||
| // it doesn't say whether the same dataset should be used for describing matched resources. | |||
| // It should be otherwise queries like DESCRIBE :A FROM :g don't make sense but one may want to | |||
| // describe resources matched in G1 based on information in G2. | |||
| Dataset aDataset = ImmutableDataset.builder() | |||
| .namedGraphs(Iterables.concat(theDataset.getDefaultGraphs(), theDataset.getNamedGraphs())) | |||
| Dataset aDataset = Datasets.builder() | |||
| @@ -74,8 +75,8 @@ public void testWordCountExtractor() throws Exception { | |||
| IRI aDocIri = aDocsConn.putDocument(new File("input.pdf").toPath()); | |||
|
|
|||
| String aQuery = "select ?wc { graph ?doc { ?doc <tag:stardog:example:wordcount> ?wc } }"; | |||
| TupleQueryResult aRes = aConn.select(aQuery).parameter("doc", aDocIri).execute(); | |||
| String wordCount = aRes.next().getBinding("wc").getValue().stringValue(); | |||
| SelectQueryResult aRes = aConn.select(aQuery).parameter("doc", aDocIri).execute(); | |||
evren
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to examples to use Stark in support of https://github.com/stardog-union/stardog/issues/6466