-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic tokeniser crashes last line isn't blank #30
Comments
I created a really simple basic file with a dangling last line... and of course it worked fine. Can you post an example? |
Huh. ...so it only seems to happen when outputting to an SSD. I attach a turnkey example, which I should totally have done in the first place --- sorry: Do:
...to run. |
That works fine too. I'm trying this on Windows, are you using something Unixy? |
I reproduced it in Windows 10's Ubuntu environment. There's a fix (I hope!) in the proposed-updates branch: https://github.com/stardot/beebasm/tree/proposed-updates |
Good to know --- belatedly, I'm on amd64 Debian. |
Incidentally, so it doesn't get lost; from #32: Line 757 of BASIC.cpp, which eats whitespace, doesn't check for EOF, so if there are two blank lines at the end of the file it eats forever until it overruns the buffer and then crashes. |
Fixed in proposed-updates: 3ee1e6a |
If you use PUTBASIC on a file where the last line doesn't end in a line feed, then beebasm seg faults.
...there's not really a lot more useful I can say; it seems completely reproducible!
This is with head of git as of writing.
The text was updated successfully, but these errors were encountered: