Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test against Ubuntu 16.04 and fix warnings #55

Merged
merged 5 commits into from
Jun 20, 2021

Conversation

davel
Copy link
Contributor

@davel davel commented Jun 20, 2021

  • Removes testing against Ubuntu 16.04 (which is now post-EOL.)
  • When building with cmake, enable -Werror
  • Fix warning emitted by clang.

/home/runner/work/beebasm/beebasm/src/symboltable.cpp:328:17: error: declaration shadows a variable in namespace 'std' [-Werror,-Wshadow]
        std::ostream & cout = (labels_file && (labels.open(labels_file), !labels.bad())) ? labels : std::cout;
                       ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/iostream:61:18: note: previous declaration is here
  extern ostream cout;          /// Linked to standard output
                 ^
@ZornsLemma ZornsLemma merged commit 86d9c09 into stardot:proposed-updates Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants