Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

feat(Text): introduced important prop to the Text component #120

Merged
merged 5 commits into from
Jul 20, 2018

Conversation

mnajdova
Copy link
Collaborator

@mnajdova mnajdova commented Jul 19, 2018

Text

Added important prop for the text.

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

Important

image

The important prop is used for styling the text to appear as more important and draw's user attention. Added a importantWeight variable to the Text component for customizing the fontWeight when using the important prop.

<Text important content="This text is important!" />

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #120 into master will decrease coverage by 0.14%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #120      +/-   ##
=========================================
- Coverage   69.94%   69.8%   -0.15%     
=========================================
  Files          74      75       +1     
  Lines        1198    1202       +4     
  Branches      227     206      -21     
=========================================
+ Hits          838     839       +1     
- Misses        355     358       +3     
  Partials        5       5
Impacted Files Coverage Δ
src/components/Text/textRules.ts 0% <0%> (ø) ⬆️
src/components/Text/textVariables.ts 0% <0%> (ø)
src/components/Text/Text.tsx 75% <100%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57ddcc...6cf2868. Read the comment docs.

@kuzhelov kuzhelov changed the title feat(Text): itroduced important prop to the Text component feat(Text): introduced important prop to the Text component Jul 20, 2018
@kuzhelov kuzhelov merged commit 0319408 into master Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants