This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
feat(Menu): added shape prop and changed the meaning of the type prop #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 10, 2018 16:59
-added examples of each shape with default and primary type
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 68.37% 68.96% +0.59%
==========================================
Files 66 67 +1
Lines 1056 1073 +17
Branches 198 204 +6
==========================================
+ Hits 722 740 +18
+ Misses 330 329 -1
Partials 4 4
Continue to review full report at Codecov.
|
levithomason
previously approved these changes
Jul 11, 2018
added 4 commits
July 11, 2018 14:22
# Conflicts: # src/components/Menu/Menu.tsx # src/components/Menu/MenuItem.tsx # src/components/Menu/menuItemRules.ts # src/components/Menu/menuRules.ts
mnajdova
changed the title
added 2 commits
July 16, 2018 11:11
# Conflicts: # docs/src/examples/components/Menu/Types/index.tsx
-added shorthand examples
kuzhelov
previously approved these changes
Jul 16, 2018
kuzhelov
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced shape prop with one of the following values:
The type prop is now used in a similar way to the button and divider (for emphasizing).
Here is how all different Menu variations can appear in default and primary style:
