This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
forked from Semantic-Org/Semantic-UI-React
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(label): added shorthand examples #99
Merged
mnajdova
merged 7 commits into
master
from
feat/label-initial-implementation-conclusion
Jul 18, 2018
Merged
feat(label): added shorthand examples #99
mnajdova
merged 7 commits into
master
from
feat/label-initial-implementation-conclusion
Jul 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 69.94% 69.94%
=======================================
Files 73 73
Lines 1191 1191
Branches 223 223
=======================================
Hits 833 833
Misses 353 353
Partials 5 5 Continue to review full report at Codecov.
|
…n-conclusion' into feat/label-initial-implementation-conclusion
kuzhelov
previously approved these changes
Jul 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
levithomason
previously requested changes
Jul 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the CHANGELOG.md. There should be an entry for this PR added under Documentation
in UNRELEASED
. See the instructions there.
kuzhelov
approved these changes
Jul 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced shorthand example to conclude the initial implementaiton