Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added savefig for saving plots as files #28

Merged
merged 2 commits into from
Dec 27, 2018
Merged

Conversation

mickvanhulst
Copy link
Contributor

In terms of documentation, I don't want to ruin the style you've created, so feel free to amend the following:

To save the plot, add save_img=True and add the file_name parameter with the directory, filename and file name extension (e.g. file_name='./folder_1/filename.png') as parameters when calling PlotLosses().

@stared
Copy link
Owner

stared commented Dec 14, 2018

Linking #14.
@mickvanhulst Ideas is nice, but code would need some refactoring.

  1. There should be only one parameter (fig_path, if None, it does not produce a plot).
  2. If you pass it, make sure to use only keyword arguments with default value None.

@mickvanhulst
Copy link
Contributor Author

@stared Reformatted code, let me know if any other work is required.

@stared
Copy link
Owner

stared commented Dec 27, 2018

@mickvanhulst Finally, I was able to test it.

It works, thanks! I am merging that.

@stared stared merged commit 033f62c into stared:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants