Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: added a new topic: Compiled class hash #1294

Merged
merged 23 commits into from
Aug 8, 2024

Conversation

raizo07
Copy link
Contributor

@raizo07 raizo07 commented Jun 11, 2024

Description of the Changes

Add a topic explaining the compiled class hash. Closes #1090.

PR Preview URL

Compiled class hash

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@raizo07 raizo07 marked this pull request as ready for review June 15, 2024 06:28
@raizo07 raizo07 changed the title doc: added an .md for the compile class hash doc: added a .md file for the compile class hash Jun 15, 2024
@stoobie
Copy link
Collaborator

stoobie commented Jul 8, 2024

@raizo07 Can you please rebase main on top of your branch? There are many directory changes that were implemented recently.

stoobie and others added 16 commits July 9, 2024 10:46
* Changed /documentation/ to /root/ in antora.yml.

* Changed root to ROOT.

* Change file names for SEO:
* underscores to hyphens
* uppercase to lowercase

* Change file names for SEO to be match content matter

* Added broken links from 3rd party sites

* Update messaging-mechanism.adoc to latest on main.

* Updated xrefs in messaging-mechanism.adoc.

* Updated URL for preview to drop `/documentation/`
…sm (starknet-io#1289)

* Change "cross-chain" to "cross-layer" in L1-L2 Messaging mechanism

* Apply suggestions from code review
* create messaging_reference.adoc
* add messaging_reference.adoc to nav
* add the functions implemented in StarknetMessaging.sol but not part of the IStarknetMessaging.sol
* Explain `deployer_address`
* Added links between consumeMessageFromL2 function and ConsumedMessageToL2 event.
* Added links between consumeMessageFromL2 function and ConsumedMessageToL2 event.
* modify event descriptions and add event heading for functions
* fix directory structure
* Comment out events from internal `processMessages` function
* Update Starknet book ToC: Update outdated information about Starknet book

---------

Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>
…o#1296)

* Update transactions.adoc with txs v3 fee estimation

* Update transactions.adoc

* Update transactions.adoc

* Update transactions.adoc

---------

Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>
…ount and declare transactions (starknet-io#1295)

* Update transaction-life-cycle.adoc with finality status of deploy_account and declare transactions

---------

Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>
…starknet-io#1302)

* add validate warnings and refactor account functions page

* fix typo

* minor fixes
* Migrating Provers topic from the Starknet Book at https://book.starknet.io/ch03-03-provers.html.

* Import sharp.adoc from the Book in order to bring in a commit with multiple contributors.

* Edits, and removed sharp.adoc
---------

Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
…knet-io#1275)

* feat: add l1 handler transaction type version

* fix: fix typo

* fix: fix typo

* fix: add a new ref to l1 handler transaction

* fix: reword L1HandlerTransaction to L1 handler transaction in normal text

* fix: reword for consistent format and better readability

* Update components/Starknet/modules/architecture-and-concepts/pages/network-architecture/messaging-mechanism.adoc

* Update components/Starknet/modules/architecture-and-concepts/pages/network-architecture/messaging-mechanism.adoc

* fix: remove old file

* Update components/Starknet/modules/architecture-and-concepts/pages/network-architecture/transactions.adoc

Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>

* fix: reword as suggested

---------

Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com>
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

stoobie
stoobie previously requested changes Jul 9, 2024
Copy link
Collaborator

@stoobie stoobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raizo07 I want @LandauRaz to review this to make sure that the technical details are correct. I reviewed the topic for clarity. One thing that I think you should state clearly is who or what uses the compiled class hash, and if there's anything that the reader needs to actually do in order to create the compiled class hash or to use it once it's created. If this is all done automatically by other components, it would be helpful to state what those components are.

@stoobie stoobie changed the title doc: added a .md file for the compile class hash doc: added a new topic: Compiled class hash Jul 9, 2024
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

4 similar comments
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@raizo07 raizo07 requested a review from stoobie July 10, 2024 16:22
@raizo07
Copy link
Contributor Author

raizo07 commented Jul 13, 2024

@LandauRaz could you kindly review this?

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1294/ .

@LandauRaz
Copy link
Collaborator

LGTM :) Thanks a lot, @raizo07!

@LandauRaz LandauRaz merged commit e690b8f into starknet-io:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for Contribution: Add a page explaining the Compiled class hash