-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suuport for some bounded_int guarantee verifications. #5870
base: dev-v2.7.0
Are you sure you want to change the base?
Conversation
ec35a69
to
353ab50
Compare
b25f6d4
to
ccaadb0
Compare
320842b
to
8e3bbbf
Compare
Suggestion:
|
next PR? Code quote: "bounded_int_felt252_constrain", |
what happens to the done label that is defined here? Code quote: validate_under_limi |
fix comment. Code quote: /// Libfunc for wrapping a given bounded int with a guarantee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r1, all commit messages.
Reviewable status: 5 of 7 files reviewed, 3 unresolved discussions (waiting on @orizi)
Suggestion: require(range.size() > &prime - (&prime % u128::MAX))
.ok_or(SpecializationError::UnsupportedGenericArg)?; |
ccaadb0
to
727ea46
Compare
commit-id:be92039f
commit-id:97bcb563
commit-id:7f79b0ef
commit-id:9653e0a0
commit-id:0f6b65a8
727ea46
to
9357138
Compare
commit-id:0f6b65a8
Stack:
This change is