Fix allowed features for generic param resolving.

[gilbens-starkware]

Stack:

• Make sub pointers depend on DeriveStorage. #5890
• Add internal feature attribute. #5889
• Fix allowed features for generic param resolving. #5888 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

a discussion (no related file):
add previously failing test.

---

---

crates/cairo-lang-defs/src/ids.rs line 320 at r1 (raw file):

impl ModuleItemId {
    pub fn as_syntax_node(&self, db: &dyn DefsGroup) -> SyntaxNode {

could you have just called stable_ptr from the outside?

[gilbens-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi)

a discussion (no related file):

Previously, orizi wrote…

add previously failing test.

Done.

---

---

crates/cairo-lang-defs/src/ids.rs line 320 at r1 (raw file):

Previously, orizi wrote…

could you have just called stable_ptr from the outside?

No, just untyped_stable_ptr and then if we want to convert it to typed one we'll have to do something similar to this.

[orizi]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

---

crates/cairo-lang-defs/src/ids.rs line 320 at r1 (raw file):

Previously, gilbens-starkware (Gil Ben-Shachar) wrote…

No, just untyped_stable_ptr and then if we want to convert it to typed one we'll have to do something similar to this.

but you don't need it type now - do you?

---

crates/cairo-lang-semantic/src/diagnostic_test_data/tests line 592 at r2 (raw file):

error: The name `BadATraitImpl` is defined multiple times.
 --> lib.cairo:45:6
impl BadATraitImpl<+UnstableTrait> of ATrait;

remove diag

[gilbens-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-defs/src/ids.rs line 320 at r1 (raw file):

Previously, orizi wrote…

but you don't need it type now - do you?

I do, not all syntax kind implement QueryAttrs.

---

crates/cairo-lang-semantic/src/diagnostic_test_data/tests line 592 at r2 (raw file):

Previously, orizi wrote…

remove diag

Done.

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware)

---

crates/cairo-lang-semantic/src/items/generics.rs line 296 at r3 (raw file):

    resolver.set_allowed_features(
        &lookup_item,
        &lookup_item.as_syntax_node(db.upcast()),

and remove all the rest.

also - consider just using this inside the set_allowed_features function.
but probably not for this PR.

Suggestion:

        &lookup_item.untyped_stable_ptr(db.upcast()).lookup(db)

[gilbens-starkware]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-semantic/src/items/generics.rs line 296 at r3 (raw file):

Previously, orizi wrote…

and remove all the rest.

also - consider just using this inside the set_allowed_features function.
but probably not for this PR.

Done.

[orizi]

Reviewed 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware)