Make sub pointers depend on DeriveStorage.

[gilbens-starkware]

This change is 

[orizi]

Reviewed 4 of 19 files at r1, all commit messages.
Reviewable status: 4 of 19 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

---

corelib/src/starknet/storage.cairo line 529 at r1 (raw file):

#[feature("simple-storage-layout")]
impl u256SubPointersImpl<
    impl i: starknet::storage_access::SimpleStorageLayout<u256>

Suggestion:

    +starknet::storage_access::SimpleStorageLayout<u256>

---

corelib/src/starknet/storage_access.cairo line 99 at r1 (raw file):

    note: "Manually implementing `SimpleStorageLayout` is not advised. Use #[derive(Store)] instead."
)]
pub trait SimpleStorageLayout<T> {}

so that the error would actually be clear.

Suggestion:

pub trait DeriveStorage<T> {}

[orizi]

Reviewed 15 of 19 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

[gilbens-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/starknet/storage.cairo line 529 at r1 (raw file):

#[feature("simple-storage-layout")]
impl u256SubPointersImpl<
    impl i: starknet::storage_access::SimpleStorageLayout<u256>

Done.

---

corelib/src/starknet/storage_access.cairo line 99 at r1 (raw file):

Previously, orizi wrote…

so that the error would actually be clear.

Done.

[orizi]

Reviewed 18 of 18 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

crates/cairo-lang-starknet/src/plugin/consts.rs line 24 at r2 (raw file):

pub const EVENT_TRAIT: &str = "starknet::Event";
pub const STORE_TRAIT: &str = "starknet::Store";
pub const SIMPLE_STORAGE_LAYOUT_TRAIT: &str = "starknet::storage_access::DeriveStorage";

rename constant.

[gilbens-starkware]

Reviewable status: 18 of 19 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-starknet/src/plugin/consts.rs line 24 at r2 (raw file):

Previously, orizi wrote…

rename constant.

Done.

[orizi]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

[orizi]

Reviewed 18 of 18 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

-- commits line 2 at r4:
reword.

[gilbens-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

---

-- commits line 2 at r4:

Previously, orizi wrote…

reword.

Done.

[orizi]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)