Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made crates references be looked up only on dependencies. #6405

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Made crates references be looked up only on dependencies. #6405

merged 1 commit into from
Sep 24, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Sep 23, 2024 •
edited
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Sep 23, 2024
Merged
Merged
Closed
Merged
Closed
@orizi orizi force-pushed the spr/main/cc2c9f4a branch 2 times, most recently from 7597b8b to f7c65d3 Compare September 23, 2024 13:24
@orizi orizi changed the base branch from spr/main/cc2c9f4a to main September 23, 2024 13:49
@orizi orizi changed the base branch from main to spr/main/3351d9de September 23, 2024 13:51
@orizi orizi changed the base branch from spr/main/3351d9de to main September 23, 2024 13:56
@orizi orizi changed the base branch from main to spr/main/3351d9de September 23, 2024 13:56
gilbens-starkware
gilbens-starkware approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

:lgtm:

Reviewed 21 of 32 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Draggu, @mkaput, and @piotmag769)

@orizi orizi changed the base branch from spr/main/3351d9de to main September 24, 2024 08:13
@orizi orizi added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 3280677 Sep 24, 2024
86 checks passed
@piotmag769 piotmag769 removed their request for review September 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae approved these changes

@gilbens-starkware gilbens-starkware gilbens-starkware approved these changes

@mkaput mkaput Awaiting requested review from mkaput

@Draggu Draggu Awaiting requested review from Draggu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orizi @Arcticae @gilbens-starkware