Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rpc state reader config to mempool node config #171

Merged
merged 1 commit into from
May 26, 2024

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented May 23, 2024

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware marked this pull request as ready for review May 23, 2024 10:47
@ArniStarkware
Copy link
Contributor Author

config/default_config.json line 80 at r1 (raw file):

    "description": "The url of the rpc server.",
    "privacy": "Public",
    "value": ""

@Yael-Starkware is this too ugly?

Code quote:

  "rpc_state_reader_config.json_rpc_version": {
    "description": "The json rpc version.",
    "privacy": "Public",
    "value": ""
  },
  "rpc_state_reader_config.url": {
    "description": "The url of the rpc server.",
    "privacy": "Public",
    "value": ""

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 49.94%. Comparing base (b11fc8f) to head (0dafa5d).

Files Patch % Lines
crates/mempool_node/src/config/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   49.88%   49.94%   +0.05%     
==========================================
  Files          21       21              
  Lines         840      841       +1     
  Branches      840      841       +1     
==========================================
+ Hits          419      420       +1     
  Misses        398      398              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dafnamatsry dafnamatsry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

@ArniStarkware ArniStarkware merged commit 8a18c5d into main May 26, 2024
13 checks passed
@ArniStarkware ArniStarkware deleted the arni/config/mempool_node/add_rpc_state_reader branch May 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants