Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(starknet_client): fix feeder gw integration test #1963

Closed
wants to merge 1 commit into from

Conversation

DvirYo-starkware
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware commented May 6, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.99%. Comparing base (e3b85bd) to head (d5c0319).
Report is 86 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
- Coverage   70.45%   69.99%   -0.47%     
==========================================
  Files         130      130              
  Lines       17011    17069      +58     
  Branches    17011    17069      +58     
==========================================
- Hits        11985    11947      -38     
- Misses       3687     3784      +97     
+ Partials     1339     1338       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware and @ShahakShama)

a discussion (no related file):
Why don't we keep jsons instead of calling the FGW


Copy link
Contributor Author

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matan-starkware, @ShahakShama, and @yair-starkware)

a discussion (no related file):

Previously, yair-starkware (Yair) wrote…

Why don't we keep jsons instead of calling the FGW

  1. Dan doesn't want to put effort into it, and the simple way is just to fix this.
  2. there is some value in doing it against the real fgw. The format of queries, check if something was changed retroactively, and get the last block.

@DvirYo-starkware DvirYo-starkware changed the title test(client): fix feeder gw integration test test(starknet_client): fix feeder gw integration test May 26, 2024
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Jun 26, 2024
@github-actions github-actions bot closed this Jul 4, 2024
auto-merge was automatically disabled July 4, 2024 08:00

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No activity for quite some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants