-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(starknet_client): fix feeder gw integration test #1963
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
- Coverage 70.45% 69.99% -0.47%
==========================================
Files 130 130
Lines 17011 17069 +58
Branches 17011 17069 +58
==========================================
- Hits 11985 11947 -38
- Misses 3687 3784 +97
+ Partials 1339 1338 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware and @ShahakShama)
a discussion (no related file):
Why don't we keep jsons instead of calling the FGW
4a4f012
to
958ccce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matan-starkware, @ShahakShama, and @yair-starkware)
a discussion (no related file):
Previously, yair-starkware (Yair) wrote…
Why don't we keep jsons instead of calling the FGW
- Dan doesn't want to put effort into it, and the simple way is just to fix this.
- there is some value in doing it against the real fgw. The format of queries, check if something was changed retroactively, and get the last block.
958ccce
to
d5c0319
Compare
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is