-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(env_var): Add support for env_var.VAR in format #4497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
force-pushed
the
env-dot
branch
2 times, most recently
from
October 18, 2022 13:38
490068d
to
31c7de5
Compare
Co-Authored-By: Segev Finer <24731903+segevfiner@users.noreply.github.com>
andytom
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but looks like we have some merge conflicts.
for some reason I cannot make this work
|
@jaimehrubiks These changes aren't included in the latest version of starship yet. They will be included with starship v1.13. |
Ups, now I see! Thank you! |
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
Co-Authored-By: Segev Finer <24731903+segevfiner@users.noreply.github.com> Co-authored-by: Segev Finer <24731903+segevfiner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows using
${env_var.VAR}
in format strings. Unlike #3375, I handled this in a shared manner with custom modules by moving the code paths for custom andenv_var
modules closer to other regular modules, leveragingmodules::handle
(which tests for custom modules were using). This allows removing the timing-handling from the custom module code.Motivation and Context
Closes #3259
Closes #3375
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: