Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use default token for release action #2920

Merged
merged 1 commit into from Jul 27, 2021
Merged

ci: Use default token for release action #2920

merged 1 commit into from Jul 27, 2021

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Jul 27, 2021

@alerque
Copy link
Contributor Author

alerque commented Jul 27, 2021

I realize it's hard to test CI jobs like this, but if you want to compare you can see this run on another project where I made exactly the same change and did a test release on a fork to verify that the upstream change had the effect it is advertised to.

matchai
matchai approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you for the PR, @alerque! 😄

@matchai matchai merged commit 82f68a0 into starship:master Jul 27, 2021
@alerque alerque deleted the cleanup-ci-workflow branch July 27, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matchai matchai matchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alerque @matchai