-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default token for simpler setup #83
Conversation
Do actions inherit this env variable without explicitly declaring it? If so I'm good to merge this |
@softprops It isn't an ENV variable. The system you were using is an ENV variable, and no those to not propagate without explicitly declaring them to be passed to an Action. What I'm doing here combines two other things: input fields which can have default values with context scoped variables, which I believe are available by default in the scope used here. I copied this arrangement from another Action that I saw using it and found it convenient, but I guess it does bear testing out to make sure there wasn't some other kind of scope magic or authorization that I missed. |
Here is an example on an Action that uses this arrangement: https://github.com/peter-evans/create-pull-request/blob/master/action.yml#L4-L6 |
@softprops I just fixed the merge conflicts, but it looks like the handling of |
I think this is a better way to get access token. When using official example here |
The repository input was likely an effect of #61 |
Yes that's where it should have come from, but it does not seem to have been implemented properly. If it was, the current documentation is surely wrong. In 94651eb the documentation was updated to reflect something different than how it should have been implemented, and honestly I can't quite make out whether it ever worked the way it was supposed to or why the documentation was changed. Where do the |
going to cut a release with current changes in then merge this into the following. |
Now using default token automatically per PR83 from softprops/action-gh-release#83
Now using default token automatically per PR83 from softprops/action-gh-release#83
99 times out of 100 people won't need anything other than the default token already available in scope, defaulting to it saves everybody YAML setup mess.