Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release test never got "SUCCESS" on Hydro #416

Open
130s opened this issue Apr 14, 2014 · 5 comments
Open

Pre-release test never got "SUCCESS" on Hydro #416

130s opened this issue Apr 14, 2014 · 5 comments
Labels

Comments

@130s
Copy link
Contributor

130s commented Apr 14, 2014

http://jenkins.ros.org/view/Prerelease/job/prerelease-hydro-rtmros_common/

Since February 2014 up to now, no test ever succeeded; either unstable or failure. Failure is fine, since it definitely needs to be taken care of immediately. Now the problem is unstable, since it makes our judgement difficult whether we can make a new release or not.

Looking at the last pre-release test, what failed are:

  • rosunit-test_hironx.xml. 0 ms 2
  • rosunit-test_hironx_ik.xml. 0 ms 2
  • rostest.runner.RosTest.testsamplerobot 5 min 38 sec 5
  • __main__.TestOpenrtmTools.test_rtshell_setup 0.16 sec 5
  • rosunit-samplerobot.xml.

test_hironx*.xml will be handled in start-jsk/rtmros_hironx#50.

What about others?

@130s 130s added the bug label Apr 14, 2014
@k-okada
Copy link
Member

k-okada commented Apr 14, 2014

I think it is because ros build firm (including devel and pre-release) did not run omniorb-nameserver[1], so we have to manually start name server[2], but there might be some issues:

  1. This script assume start start_omninames.sh before all other nodes, however roslaunch did not guarantee the order of executing the process.
  2. Currently I put start_omninames.sh everyware, opnehrp3, hrpsys, rtmbuild. That is redundant. I think we should rtm-naming in openrtm_aist package, but the script did not keep the nameserver process in foreground. so we need patch.
start_omninames()
{
    echo 'Starting omniORB omniNames: '$hostname':'$port
    rm -f ./omninames-$hostname.log
    rm -f ./omninames-$hostname.bak
    $cosnames -start $port -logdir $currdir &

[1] ros-infrastructure/jenkins_scripts#67 (comment)
[2] k-okada@4de5338

@130s
Copy link
Contributor Author

130s commented Jun 23, 2014

  1. Currently I put start_omninames.sh everyware, opnehrp3, hrpsys, rtmbuild. That is redundant.

Hmm, indeed.

I think we should rtm-naming in openrtm_aist package, but the script did not keep the nameserver process in foreground. so we need patch.

Is there any reason why this patch is not yet applied? And where is this patch supposed to be applied?

@k-okada
Copy link
Member

k-okada commented Jun 23, 2014

Is there any reason why this patch is not yet applied? And where is this patch supposed to be applied?

this should be patched against OpenRTM-aist-1.1.0/utils/rtm-naming/rtm-naming, but in order to keep original behavior, i think it is better to use command line option for proposed behavior.

@130s
Copy link
Contributor Author

130s commented Jun 23, 2014

this should be patched against OpenRTM-aist-1.1.0/utils/rtm-naming/rtm-naming,

I see.

but in order to keep original behavior,

I see.

i think it is better to use command line option for proposed behavior.

How is this achievable on buildfarm?
Since I'm not familliar, I just opened a PReq to workaround in the same way it's done in hrpsys and other package while I'm open to implement more optimal solution later.

@k-okada
Copy link
Member

k-okada commented Jun 24, 2014

How is this achievable on buildfarm?

on is to send patch to openrtm-users and wait for new release, other is to
add patch file
https://github.com/start-jsk/openrtm_aist_core/tree/master/openrtm_aist/patch,
but in that case we have to release package without updating package
version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants