Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rtc name ;; Absoluteforcesensor => RemoveForceSensorLinkOffset #397

Merged
merged 1 commit into from
May 24, 2014

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Apr 1, 2014

Update rtc name ;; Absoluteforcesensor => RemoveForceSensorLinkOffset
according to hrpsys-base commit ;; https://code.google.com/p/hrpsys-base/source/detail?r=1040

@k-okada
Copy link
Member

k-okada commented Apr 1, 2014

do we have to check if this patch is ok, after we update hrpsys package to trunk?

@snozawa
Copy link
Contributor Author

snozawa commented Apr 2, 2014

Yes, if the update
https://code.google.com/p/hrpsys-base/source/detail?r=1040
is added to hrpsys-base tags, the travis checking about this PReq wiil pass.

@k-okada
Copy link
Member

k-okada commented Apr 19, 2014

I thought that I commented a few days ago but may be it is my misunderstanding

If this PR is just a renaming, how about we revert https://code.google.com/p/hrpsys-base/source/detail?r=1040 and do not apply until just before we release 315.2.x .

@k-okada
Copy link
Member

k-okada commented Apr 19, 2014

I already commented same things at start-jsk/hrpsys#75 (comment)

…h, hrpsys_ros_bridge/scripts/sensor_ros_bridge_connect.py : rename AbsoluteForceSensor => RemoveForceSensorLinkOffset
@snozawa
Copy link
Contributor Author

snozawa commented May 24, 2014

This PR has no influence on stable rtcs, so I can merge this PR according to the discussion[1].
I'll close similar PR[2].

[1] #449
[2] #466

snozawa added a commit that referenced this pull request May 24, 2014
@snozawa snozawa merged commit 31a7b1b into start-jsk:master May 24, 2014
@snozawa snozawa deleted the rename_afs_rmfo branch July 2, 2014 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants