Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support odom topic #424

Closed
wants to merge 13 commits into from
Closed

Conversation

garaemon
Copy link
Member

do not publish /odom tf frames but publish /odom topic (nav_msgs/Odometory).
see #409 for more detail.

It required hrpsys trunk

Conflicts:
	hrpsys_ros_bridge/package.xml
@k-okada
Copy link
Member

k-okada commented Apr 15, 2014

@garaemon, if you could not wait for discussion start-jsk/hrpsys#75 and start-jsk/openhrp3#43, you can create branch at rtmros_common, for example devel or hrpsys_trunk and continue developping,

As for hrpsys package, you just locally change https://github.com/start-jsk/hrpsys/blob/master/Makefile.hrpsys-base#L7

@garaemon
Copy link
Member Author

creating hrpsys trunk branch is a reasonable idea.

Because in order to test trunk related codes on real robot, we need to
merge several PRs.

@snozawa what do you think about it ?

2014年4月16日水曜日、Kei Okadanotifications@github.comさんは書きました:

@garaemon https://github.com/garaemon, if you could not wait for
discussion start-jsk/hrpsys#75https://github.com/start-jsk/hrpsys/issues/75and
start-jsk/openhrp3#43 start-jsk/openhrp3#43,
you can create branch at rtmros_common, for example devel or hrpsys_trunk
and continue developping,

As for hrpsys package, you just locally change
https://github.com/start-jsk/hrpsys/blob/master/Makefile.hrpsys-base#L7


Reply to this email directly or view it on GitHubhttps://github.com//pull/424#issuecomment-40492292
.

from iPhone

@garaemon
Copy link
Member Author

@snozawa
Copy link
Contributor

snozawa commented Apr 15, 2014

I think creating branch is reasonable, too.
Currently, using hrpsys-base trunk code is necessary for the real robots.

@k-okada
Copy link
Member

k-okada commented Apr 19, 2014

I don't understand all codes, but it seems this can be merged if you revert
fkanehiro/hrpsys-base@430aa95
commit on https://github.com/fkanehiro/hrpsys-base

#397 (comment)

@garaemon
Copy link
Member Author

I will work on this PR to merge into master

@garaemon
Copy link
Member Author

I will update this PR to remove changes included in #397

@garaemon garaemon mentioned this pull request May 29, 2014
@garaemon
Copy link
Member Author

updated PR to #476

@garaemon garaemon closed this May 29, 2014
@garaemon garaemon deleted the support-odom-imu-topic branch May 29, 2014 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants