Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): TE-2334 fix type error on view subscription groups page #1457

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

harshilvelotio
Copy link
Collaborator

Issue(s)

https://startree.atlassian.net/browse/TE-2334

Description

  • Possible fix for a type error on view subscriptions page

Screenshots

image

Attach screenshots of UI/UX changes, if applicable.

How to test

  • Go to Configuration -> Subscription groups

@harshilvelotio harshilvelotio requested a review from a team as a code owner June 10, 2024 11:36
@github-actions github-actions bot added the thirdeye-ui Updates to thirdeye-ui project label Jun 10, 2024
Copy link
Collaborator

@cyrilou242 cyrilou242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshilvelotio harshilvelotio merged commit b87705f into master Jul 2, 2024
3 checks passed
@harshilvelotio harshilvelotio deleted the harshil/TE-2334-fix-type-error-subgroups branch July 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thirdeye-ui Updates to thirdeye-ui project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants