Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Usability issue with updated scrape with menu #5233

Closed
cj12312021 opened this issue Sep 7, 2024 · 0 comments · Fixed by #5235
Closed

[Bug Report] Usability issue with updated scrape with menu #5233

cj12312021 opened this issue Sep 7, 2024 · 0 comments · Fixed by #5235
Labels
bug report Bug reports that are not yet verified

Comments

@cj12312021
Copy link
Collaborator

cj12312021 commented Sep 7, 2024

Describe the bug
This one isn't really a bug but a usability issue I was having. My muscle memory has me always reaching for the top item on the list when I want to use the StashDB scrapper (I imagine other users will run into the issue as well). However, with the recent change, a reload scrapper button, as well as a query filter, now exist with the reload button placed above the query filter. The placement makes my muscle memory think that the reload button is the first scrape option, leading me to always click that when attempting to use the StashDB scrapper.

Also see discussion on discord https://discordapp.com/channels/559159668438728723/559159910550732809/1282062156938084383

To Reproduce
Steps to reproduce the behavior ():

  1. Ensure you have at least 5 scrappers installed to your Stash.
  2. Enter the Scene Details page
  3. Navigate to the Edit tab
  4. Presh the Scrape with...

Expected behavior
A solution similar to the below implementation CSS (done with just CSS for ease of implementation outside of the source code) would be a better approach. It removes the reload button from the top and fixes it to the left of the text input field without the Reload Scrappers. The CSS also positions both those elements so they are stuck and stay on screen when scrolling through scrappers.

Screen_Recording_2024-09-07_143039.1.mp4

Since we'll have access to the DOM, some of the CSS tweaks can be bypassed by moving the reload button group where the reload button sits to the right of the text input element. This will ensure no conflicts with the clear text button when it appears. On the reload button, we would add a tooltip when hovering with the Reload scrapers text. This way, we can eliminate the label used directly next to the button. The refresh/reload icon here has a pretty universal meaning so there should be much confusion. As you can see in my CSS implementation, ideally, the search field would have its own color to make it more identifiable.

Screenshots
[If applicable, add screenshots to help explain your problem please ensure that your screenshots are SFW or at least appropriately censor

Screen_Recording_2024-09-07_142940.mp4
@cj12312021 cj12312021 added the bug report Bug reports that are not yet verified label Sep 7, 2024
@cj12312021 cj12312021 changed the title [Bug Report] Short Form Subject (50 Chars or less) [Bug Report] Usability issue with updated scrape with menu Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant