New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find correct python executable #1156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpedNSFW
force-pushed
the
python-wrapper
branch
from
February 27, 2021 08:01
e182c75
to
64ff772
Compare
For script scrapers using python, both python and python3 are valid depending on the OS and running environment. To save users from having any issues, this change will find the correct executable for them.
SpedNSFW
force-pushed
the
python-wrapper
branch
from
February 27, 2021 08:14
64ff772
to
2ed0a72
Compare
bnkai
reviewed
Feb 28, 2021
Co-authored-by: bnkai <bnkai@users.noreply.github.com>
WithoutPants
requested changes
Mar 1, 2021
bnkai
approved these changes
Mar 1, 2021
WithoutPants
approved these changes
Mar 2, 2021
elad-lachmi
pushed a commit
to elad-lachmi/stash
that referenced
this pull request
Mar 23, 2021
* find correct python executable For script scrapers using python, both python and python3 are valid depending on the OS and running environment. To save users from having any issues, this change will find the correct executable for them. Co-authored-by: bnkai <bnkai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For script scrapers using python, both python and python3 are valid depending on the OS and running environment. To save users from having any issues, this change will find the correct executable for them.