Add exclude file from scan feature #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnkai
changed the title
* Abort exclusion instead of panicking when pattern isn't valid
|
will the exclude file follow gitignore styling or some kind of YAML configuration in some way? |
|
It is in the config file as an extra option |
bnkai
changed the title
WithoutPants
requested changes
Dec 13, 2019
* changed behavior of exclude function to continue and ignore invalide regex patterns * added some more tests (windows networks and continue after regex error)
This was referenced Dec 13, 2019
|
One last QA check before we merge this. |
WithoutPants
requested changes
Dec 16, 2019
|
From testing, I think the exclusions should also apply when performing a clean. Currently, it does not apply these. |
it's supposed to be only for the Scan, i'll create a separate PR with an option for the Clean |
|
I think i changed everything needed , not 100% sure on the tsx formatting i did it manually. |
WithoutPants
approved these changes
Dec 17, 2019
Leopere
approved these changes
Dec 17, 2019
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Added exclude file from scan feature * Abort exclusion instead of panicking when pattern isn't valid * Added UI configuration for exclude patterns * * cosmetic fixes * changed behavior of exclude function to continue and ignore invalide regex patterns * added some more tests (windows networks and continue after regex error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a basic regexp pattern matching file exclusion.
You can add the patterns in the config file or directly from the UI
For the config file
the first excludes all files ending in
sample.mp4the second hidden directories
/.directory/the third should work for windows based directories (the \ needs double escaping)
and so on
If added through the UI you don't need to escape the
\character