Lazy load images #4228
Merged
Lazy load images #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DingDongSoLong4
approved these changes
Oct 22, 2023
DingDongSoLong4
pushed a commit
to DingDongSoLong4/stash
that referenced
this pull request
Oct 25, 2023
* Add lazy loading for many images * Load sprites on first hover of scrubber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
loading="lazy"to many card thumbnails and similar images. This means that these images will be loaded when the component comes into view, rather than loading everything at once. Also changes the behaviour of the hover scrubber to only load the vtt and sprites when the user first hovers over the scrubber.This should improve performance when querying for objects with a large page size.
Should fix #4211