New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package manager UI-related tweaks #4382
Merged
WithoutPants
merged 14 commits into
stashapp:develop
from
DingDongSoLong4:package-manager-tweaks
Dec 22, 2023
Merged
Package manager UI-related tweaks #4382
WithoutPants
merged 14 commits into
stashapp:develop
from
DingDongSoLong4:package-manager-tweaks
Dec 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DingDongSoLong4
force-pushed
the
package-manager-tweaks
branch
from
December 20, 2023 23:22
aaa9970
to
e8541a3
Compare
DingDongSoLong4
force-pushed
the
package-manager-tweaks
branch
from
December 21, 2023 00:30
e8541a3
to
efc8277
Compare
Added two more tweaks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a bunch of improvements and tweaks mostly related to the package manager UI.
SetPluginsEnabled
mutation to modify the cache client-side and avoid any refetching. I've also done some minor refactoring (the package manager mutations now useclient.mutate
rather than hooks), and I've removed thesources
state which is no longer necessary since the cache is now being properly invalidated.flex-grow
spacer rather thanspace-between
.<unknown>
if the package has no version specified, rather than showing nothing.upgrade
GraphQL field is nowsource_package
, and will always return a result if the package is available from the source. This change means that an upgrade needs to be highlighted in some other way, which I've done by making the text bold and adding an icon.py_common
). The first is that theinstalledPackages
query doesn't return a stable sort order, which happens becausesortedPackageSpecKeys
only sorts by ID - it will now fall back to the source URL. The second issue happens when deselecting packages - if you select bothpy_common
packages, and then deselect one of them, both of them will be deselected. This is again simply fixed by including the source URL in comparisons.I've tried my best to demonstrate most of the changes in these two screenshots:
Before:
After:
Closes #4377
Resolves #4230