Enable track activity by default #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sets the track activity field to true for existing systems as well, unless the user has enabled/disabled the track activity switch in the past. If we are going ahead with this change, then we must have a release note indicating that the track activity switch will be set to true and the user needs to manually disable it. |
|
I've added release notes for this change, and I've changed the setting name from |
|
Thanks! That sounds good to me. |
8 tasks
damontecres
added a commit
to damontecres/StashAppAndroidTV
that referenced
this pull request
Jun 19, 2024
Fixes #299 Tracking activity was changed to default to `true` in stashapp/stash#4710, but this app would default it to `false` if the server didn't provide a value. The server won't provide a value by default until the user explicitly changes the setting. This means, for example, a brand new install of server version `0.26.1` would have server-side tracking enabled but would not provide the value in the UI config query. So this app would read it as a `null` value and translate that to `false`. This PR fixes this behavior so that if the server is at least `0.26.0` and no value is provided by the server, it will default to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the track activity setting to true by default on new Stash configurations. New users often ask about automatically updating the ply count without realizing this setting exists.