Validate custom locale and javascript strings #4893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4841 (in terms of improving UX when invalid code is input)
Validates the custom localisation string and displays an error if it is invalid:
![image](https://private-user-images.githubusercontent.com/53250216/334287468-f9ae6bc4-6fcf-4738-81ca-a955d7c56997.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NjgzMDMsIm5iZiI6MTcxOTU2ODAwMywicGF0aCI6Ii81MzI1MDIxNi8zMzQyODc0NjgtZjlhZTZiYzQtNmZjZi00NzM4LTgxY2EtYTk1NWQ3YzU2OTk3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDA5NDY0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkZTYzM2FlOGJmNjU1ODVhMTM2NmZiOTQyYTg1ZjZhYjBjMjI4NmIwYWI2Yzk5NDMyNTgwNjEzYmYyMDUxODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.dt1bD-YLkCYrfGrNDYkbNFUILOfQt9Sj5fEwlas80D0)
It will not be possible to save the string if it has errors.
Validates the custom javascript string for syntax errors, and displays an error if it is invalid:
![image](https://private-user-images.githubusercontent.com/53250216/334287808-d0a24be0-0857-48ba-8583-bc2d116be0a4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NjgzMDMsIm5iZiI6MTcxOTU2ODAwMywicGF0aCI6Ii81MzI1MDIxNi8zMzQyODc4MDgtZDBhMjRiZTAtMDg1Ny00OGJhLTg1ODMtYmMyZDExNmJlMGE0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDA5NDY0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg2ZGI2OTEwODA3MzI2YzgzMGJiN2I5YTAwMDVlZjJhNmE1YWRlNzQ4NTk5NmZjMGM3OGY0YTNmOTc0N2QzMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kLDjCUrDodiI68mQKyBClJeJquZeNkIcPQwT4wGw-VM)
No validation is performed for custom css as I could find no simple way to do it.