Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid view, image to tag #641

Merged
merged 19 commits into from
Jul 7, 2020
Merged

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Jun 29, 2020

Resolves #5

Adds schema migration to add tag image.

Adds grid view to tags page. Tags without images have a default image displayed (not stored), as shown below:

image

Clicking on the scene or marker icon in the card navigates to the applicable query view.

Leaves the old (ugly) view in under the list view.

Adds an individual tag page, allowing editing and viewing the scenes and markers with the tag:

image

Tags are now exported in their own folder.

Also adds a check to ensure tag name is unique at creation/modification. I did this rather than a schema migration in case people have duplicate tag names in their database.

Marking as draft while I add the following features:

  • add is missing image filter
  • add filter by scene/marker count
  • add sort by scene/marker count

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Jun 29, 2020
@WithoutPants WithoutPants added this to the Version 0.3.0 milestone Jun 29, 2020
@WithoutPants WithoutPants marked this pull request as ready for review June 29, 2020 04:53
@bnkai
Copy link
Collaborator

bnkai commented Jul 6, 2020

Tested for a couple of days, it seems ok.

@WithoutPants WithoutPants merged commit 244ae54 into stashapp:develop Jul 7, 2020
@echo6ix
Copy link
Contributor

echo6ix commented Jul 7, 2020

This looks really good!

Not sure if this is the right fourm but here are two suggestions:

  1. Add a button to delete an existing image.
  2. When uploading an image, add a crop feature while the image is being uploaded, such as this, at a set aspect ratio, such as 1:1 or 4:3, so all images are the same aspect ratio. This will make the tag images look so much better if they all share the same aspect ratio.

@WithoutPants
Copy link
Collaborator Author

@echo6ix can you raise this in a new issue please? :)

Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add grid view for tags
* Add tag page
* Import/export tags
* Add tag name uniqueness checks
* Fix styling on missing marker previews
* Add trace loglevel
* Add SQL trace
* Add filter options for tags
* Add tag sort by options
* Add tag page keyboard shortcuts
@WithoutPants WithoutPants deleted the tag-images branch February 4, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Tag thumbnails
3 participants