-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grid view, image to tag #641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested for a couple of days, it seems ok. |
This looks really good! Not sure if this is the right fourm but here are two suggestions:
|
@echo6ix can you raise this in a new issue please? :) |
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Add grid view for tags * Add tag page * Import/export tags * Add tag name uniqueness checks * Fix styling on missing marker previews * Add trace loglevel * Add SQL trace * Add filter options for tags * Add tag sort by options * Add tag page keyboard shortcuts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5
Adds schema migration to add tag image.
Adds grid view to tags page. Tags without images have a default image displayed (not stored), as shown below:
Clicking on the scene or marker icon in the card navigates to the applicable query view.
Leaves the old (ugly) view in under the list view.
Adds an individual tag page, allowing editing and viewing the scenes and markers with the tag:
Tags are now exported in their own folder.
Also adds a check to ensure tag name is unique at creation/modification. I did this rather than a schema migration in case people have duplicate tag names in their database.
Marking as draft while I add the following features:add is missing image filteradd filter by scene/marker countadd sort by scene/marker count