Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear image #722

Merged
merged 7 commits into from Aug 11, 2020
Merged

Clear image #722

merged 7 commits into from Aug 11, 2020

Conversation

WithoutPants
Copy link
Collaborator

Partially resolves #660

Adds a clear image button to the edit tags, performers, studios and movies (front and back) pages.

image

Performer image now generates a random image using the name as a seed, and uses that image if there is none set. All other types use their default image if none is set.

Movie front image is a little bit of a hack. If the back image is set but the front image is not, then the front image will be set in the database from the default image, since the front image cannot currently be nulled, and I didn't want to add a schema change to fix it. This will mean unexpected behaviour when querying for missing front image if the back image is set.

Adds is missing image for tags, studios, performers and movies. Note that existing users will find that is missing will not find results for their existing data which had the default images populated (they aren't null).

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Aug 11, 2020
@WithoutPants WithoutPants added this to the Version 0.3.0 milestone Aug 11, 2020
@bnkai
Copy link
Collaborator

bnkai commented Aug 11, 2020

For movies that only have a front cover clicking on the clear front image and then saving gives you
ErrorGraphQL error: NOT NULL constraint failed: movies_images.front_image.
Clicking on clear back image afterwards and then hitting save lets you clear the front image.
The hack also makes it impossible to filter on missing front images for movies with only back images (just realised you already mentioned that)
EDIT for the rest it works as intended. For tags is missing image works even with existing data.

@WithoutPants
Copy link
Collaborator Author

Movie image clearing should be fixed now.

@WithoutPants WithoutPants merged commit e16118f into stashapp:develop Aug 11, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Allow clearing of tag images
* Allow clearing of studio images
* Allow clearing of performer images
* Allow clearing of movie images
* Add filtering for missing images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Tag grid view enhancements (delete button, image cropper)
2 participants