Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New variable from type field of AppBinding + Fix RoleBinding name conflict with KubeDB #845

Merged
merged 7 commits into from
Aug 2, 2019
Merged

New variable from type field of AppBinding + Fix RoleBinding name conflict with KubeDB #845

merged 7 commits into from
Aug 2, 2019

Conversation

hossainemruz
Copy link
Contributor

@hossainemruz hossainemruz commented Jul 26, 2019 •
edited
Loading

Requirements:

Task:

  • Use database type as prefix of Repository and BackupConfiguration
  • Test manually
  • Update docs

@tamalsaha
Copy link
Member 

t = postgres
g = ""
r = postgres

GVR
GVK

TARGET_APP_TYPE     := kubedb.com/postgres
TARGET_APP_GROUP    := kubedb.com
TARGET_APP_RESOURCE := postgres

prefix: ${NS}/postgres/{name}

@codecov-io
Copy link

codecov-io commented Jul 30, 2019 •
edited
Loading

Codecov Report

Merging #845 into master will decrease coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   35.67%   35.29%   -0.38%     
==========================================
  Files          13       13              
  Lines        1141     1153      +12     
==========================================
  Hits          407      407              
- Misses        665      677      +12     
  Partials       69       69
Impacted Files Coverage Δ
pkg/restic/metrics.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec6caf...bf58045. Read the comment docs.

@tamalsaha
Copy link
Member

@hossainemruz , can you fix the conflicts?

@tamalsaha tamalsaha force-pushed the templated-name-prefix branch 2 times, most recently from bfe4d25 to 0261f48 Compare July 30, 2019 16:52
@tamalsaha tamalsaha mentioned this pull request Jul 30, 2019
Merged
tamalsaha
tamalsaha reviewed Jul 30, 2019
View reviewed changes
pkg/controller/appbindings.go Outdated
@@ -58,6 +58,8 @@ func (c *StashController) applyBackupAnnotationLogicForAppBinding(ab *appCatalog
return fmt.Errorf("failed to create reference of %s %s/%s. Reason: %v", ab.Kind, ab.Namespace, ab.Name, err)
}

targetAppGroup, targetAppResource := ab.GroupResource()
Copy link
Member

@tamalsaha tamalsaha Jul 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are optional & it should be ok for these to be empty. Just not usable in that case.

See here: https://github.com/kmodules/custom-resources/blob/master/apis/appcatalog/v1alpha1/appbinding_test.go#L17

@hossainemruz hossainemruz changed the title Use database type as prefix of Repository and BackupConfiguration WIP: Use database type as prefix of Repository and BackupConfiguration Jul 31, 2019
@hossainemruz hossainemruz mentioned this pull request Aug 1, 2019
Merged
22 tasks
@hossainemruz hossainemruz changed the title WIP: Use database type as prefix of Repository and BackupConfiguration New variable from type field of AppBinding + Fix RoleBinding name conflict with KubeDB Aug 1, 2019
@tamalsaha tamalsaha merged commit 998fac0 into master Aug 2, 2019
@tamalsaha tamalsaha deleted the templated-name-prefix branch August 2, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamalsaha tamalsaha tamalsaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hossainemruz @tamalsaha @codecov-io